aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

Add webhook framework

Open kerthcet opened this issue 10 months ago • 6 comments

Pull Request Description

  • add the webhook for validations, which uses an internal cert.
  • add the integration test framework and add a simple example
  • Update the update-codegen.sh

Related Issues

xref: https://github.com/aibrix/aibrix/issues/710

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • [ ] PR title includes appropriate prefix(es)
  • [ ] Changes are clearly explained in the PR description
  • [ ] New and existing tests pass successfully
  • [ ] Code adheres to project style and best practices
  • [ ] Documentation updated to reflect changes (if applicable)
  • [ ] Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

kerthcet avatar Feb 19 '25 12:02 kerthcet

I hope to push the changes commit by commit, however, the dependency is really coupled, so ...

kerthcet avatar Feb 20 '25 03:02 kerthcet

I think the doc build error is not related because it's a private repo at this moment.

kerthcet avatar Feb 20 '25 03:02 kerthcet

Failed by TestBaseModelInferenceFailures/Invalid_API_Key, rerun.

kerthcet avatar Feb 20 '25 08:02 kerthcet

Could you take a look @Jeffwan This is the first step to introduce the webhook framework. Thanks!

kerthcet avatar Feb 20 '25 08:02 kerthcet

I was busy on the open source stuff yesterday. I will spend some time on the review todya

Jeffwan avatar Feb 21 '25 01:02 Jeffwan

doc build failure is expected, I switch to free version and it only supports public repo. It will come back soon

Jeffwan avatar Feb 21 '25 01:02 Jeffwan

@kerthcet #740 and #741 have been merged. We can revisit this one now

Jeffwan avatar Feb 26 '25 05:02 Jeffwan

Migrate to https://github.com/vllm-project/aibrix/pull/748 as a forked repo's PR. I'll close this one.

kerthcet avatar Feb 26 '25 06:02 kerthcet