aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

Improve the autoscaling benchmark scripts

Open Jeffwan opened this issue 10 months ago • 1 comments

🚀 Feature Description and Motivation

Copy some TODO items from issue https://github.com/aibrix/aibrix/pull/650

WIP items:

  • [ ] Improving aibrix/benchmarks/generator/client.py with async and streaming mode
    • [ ] TTFT
    • [ ] TPOT
    • [ ] Goodput
  • [ ] Adjust the QPS scale
  • [ ] Improving plot script
    • [ ] Tokens/s times series plot
    • [ ] TTFT times series plot
    • [ ] TPOT times series plot
    • [ ] Goodput times series plot

Use Case

This is to improve the qualify of the autoscaling experiments

Proposed Solution

No response

Jeffwan avatar Feb 13 '25 18:02 Jeffwan

Addressing in https://github.com/aibrix/aibrix/pull/676

happyandslow avatar Feb 17 '25 22:02 happyandslow

@happyandslow what's the status of this story?

  1. All above metrics in the issue description are all collected?
  2. Did you make changes to the plot diagram?
  3. is #667 resolved?

Jeffwan avatar Apr 28 '25 23:04 Jeffwan

@happyandslow Any updates?

Jeffwan avatar May 05 '25 20:05 Jeffwan

@happyandslow Any updates?

The modification is applied to #676 Improving aibrix/benchmarks/generator/client.py with async and streaming mode

  • [x] TTFT
  • [x] TPOT
  • [x] Goodput
  • [x] Adjust the QPS scale

Improving plot script

  • [x] Tokens/s times series plot
  • [x] TTFT times series plot
  • [x] TPOT times series plot
  • [ ] Goodput times series plot

I'm leaving out Goodput since it is a one time measurement throughout the entire experiment.

I'm waiting for some free cycles to test these out before PR can be merged.

happyandslow avatar May 05 '25 22:05 happyandslow

I'm waiting for some free cycles to test these out before PR can be merged.

@happyandslow

Do you mean the changes has been included in #676 or in coming PR?

Can you confirm whether #667 is resolved or not?

Jeffwan avatar May 06 '25 21:05 Jeffwan

#667 should solved (check comments) The changes I was going to try were #862

happyandslow avatar May 06 '25 21:05 happyandslow

Great. We can close this issue, we can revisit #862 once it's ready.

Jeffwan avatar May 08 '25 00:05 Jeffwan