aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

The current e2e tests are flaky

Open Jeffwan opened this issue 10 months ago • 8 comments

🐛 Describe the bug

Image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response

Jeffwan avatar Feb 12 '25 01:02 Jeffwan

this is kind of painful now. the job takes very long, eventually failed and it lots of runtime.

Jeffwan avatar Feb 13 '25 17:02 Jeffwan

Image

Jeffwan avatar Feb 13 '25 17:02 Jeffwan

@varungup90 If you have not started this issue, I will take it over.

Jeffwan avatar Feb 13 '25 17:02 Jeffwan

Image

I can reproduce the issue on my end but my setup is not 100% same as kind setups. I run e2e against my mac for desktop directly. I will double check that part and come back to this issue

Jeffwan avatar Feb 13 '25 19:02 Jeffwan

Image

Jeffwan avatar Feb 13 '25 19:02 Jeffwan

What is the rootcause?

varungup90 avatar Feb 13 '25 21:02 varungup90

Image

Image

Image

unexpected EOF is the last issue. It happens to miss one request.

Jeffwan avatar Feb 14 '25 01:02 Jeffwan

Image https://github.com/openai/openai-go?tab=readme-ov-file#retries

It actually retried up to 3 times for 500 like issues. However, seems last request is commonly lost, ends up seeing 401 unexpected EOF issues. It has been verified by checking the headers for coming requests

Image

This could be gateway extension problems. I do not know the root cause. One thing we can do is to disable retry for this case.

client := openai.NewClient(
	option.WithMaxRetries(0), // default is 2
)

Jeffwan avatar Feb 14 '25 01:02 Jeffwan

Presently, e2e tests are working fine. I will close this issue.

varungup90 avatar Apr 04 '25 17:04 varungup90