lib is incompatible with latest angular 12

[papirosko]

"@angular/common": "^12.2.7", (at the time of writing there is also 12.2.16) gives the following:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^12.2.7" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"12.1.2" from [email protected]
npm ERR! node_modules/ng2-date-picker
npm ERR!   ng2-date-picker@"12" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

you should use ^ in peerDependencies

[vlio20]

@papirosko you should use the 12* version of this lib with ng12 app. Let me know if it works

[papirosko]

I am:

npm install ng2-date-picker@12 --save the problem is that you have strict angular version 12.1.2 in peer dependencies, and should use smth like

"@angular/common": "^12.0.0"

here: https://github.com/vlio20/angular-datepicker/blob/12.0.4/package.json#L41

[vlio20]

Good point. Do you want to create a PR with a fix for that version?

[papirosko]

no, switched to another datepicker...

[ArthurDrevot]

Hello, I am having the same problem. Can I create a PR to fix this? And reopen the ticket?

[vlio20]

Sure, reopenning.

[ArthurDrevot]

PR : https://github.com/vlio20/angular-datepicker/pull/634

but I don't know which branch to merge on

[ArthurDrevot]

@vlio20 Can you create a new '12.0.5' branch from the '12.0.4' branch so that I can merge my branch into it?

Is it possible afterwards to create the version and push it to NPM?