vletoux

Indeed in VRE.transmit, you do not get the size of the array sent (https://github.com/martinpaljak/vJCRE/blob/master/src/pro/javacard/vre/VRE.java#L207-L211) So when APDU.receiveBytes is called: - the data copy to the APDU buffer is not made...

sendBytesLong doesn't throw an exception if setOutgoingLength not called

1

According to http://www.win.tue.nl/pinpasjc/docs/apis/jc222/javacard/framework/APDU.html#sendBytesLong%28byte[],%20short,%20short%29 "throws:(...) APDUException.ILLEGAL_USE if setOutgoingLength() not called or setOutgoingAndSend() previously invoked or response byte count exceeded or if APDUException.NO_T0_GETRESPONSE or APDUException.NO_T0_REISSUE or APDUException.NO_T0_REISSUE previously thrown. " Indeed no...

reproduce: kp = new KeyPair(KeyPair.ALG_RSA_CRT, KeyBuilder.LENGTH_RSA_1024); kp.genKeyPair();

OwnerPIN check and update issue when using an offset

2

in /src/javacard/framework/OwnerPIN.java (https://github.com/martinpaljak/vJCRE/blob/85c7828089fcde0fa8cde89a622b5ec582804947/src/javacard/framework/OwnerPIN.java) The **offset** parameter of the functions **check** and **update** is not used. My opinion is that: Util.arrayCopy(pin, (short)0, value, (short)1, length); should be changed to Util.arrayCopy(pin, offset,...

The tool is very good. However it is difficult to test functions involving selectingApplet() returning true except doing test with a hardcoded value of "true". Hopefully, this is case only...

Better logging in case of API call error

1

I'm going through an error I'm trying to debug. Indeed, when I got an alert, nothing is inserted into TheHive. So I added the debugging. Unfortunately nothing is written ```...

I found out there is a couple of checks missing. First: https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/winpmem.cpp#L422 If there is no more space on the disk, WriteFile Fails, then copy_memory fails, then write_raw_image succeed. The...

Add flush after printf

2

Thanks for this excellent tool ! I tried to add a GUI over WinPmem for end user by redirecting stdin and stdout. Short version: the output get buffered all at...