Vlad Poluch comments

Results 61 comments of


                                            Vlad Poluch

FirebaseError type definition as class instead of interface

Also using **enum** with comments instead of **string literal** could be a better improvement. ``` enum FirebaseErrorCode { /** Thrown if a method is called with incorrect arguments. */ AUTH_ARGUMENT_ERROR...

FirebaseError type definition as class instead of interface

@vinayuttam https://github.com/firebase/firebase-admin-node/issues/179

How to read the declared metadata on a field or prop ?

You have to use internal API to get this kind of data. Check a code and how internally `class-validator` works/store data you need.

feat: add decorator to check if two properties match

We do not have validator for this. Feel free open PR.

feat: validateOrReject should throw instance of Error

I do not understand why you need another method. In case you use `validateOrReject` you know promise is rejected and you have to handle it. Otherwise you will use `validateSync`

feat: validateOrReject should throw instance of Error

Sure I understand now. But it is breaking change. We have to bundle this to next major release.

feat: validateOrReject should throw instance of Error

Sure why not. Let's introduce new `validateOrThrow` method and mark `validateOrReject` as deprecated.

@matches with my regex shows true sometimes while false sometimes

@rubiin Did you resolve your issue?

documentation: default settings for class-validator allows arbitrary bypass vulnerability

Transformation plain json object into class instance is not `class-validator` responsibility. I think this should be handled on `class-transformer` side.

documentation: default settings for class-validator allows arbitrary bypass vulnerability

I think for this purpose exists option `forbidUnknownValues`. It will return validation error in case `class-validator` dont know target class of validated object. I know the name of option is...