vscode-vlang icon indicating copy to clipboard operation
vscode-vlang copied to clipboard

Added i32 as a type for syntax highlight

Open txgruppi opened this issue 3 years ago • 7 comments

I think the title says it all

txgruppi avatar Feb 08 '22 15:02 txgruppi

Right now, i32 is a type alias, not a "real" type.

JalonSolov avatar Feb 08 '22 15:02 JalonSolov

@JalonSolov but it is still a type. Why not highlight it as one.

I think this is not a dicussion to have in this repo but shouldn't i32 by the concrete type and int the alias. After all we have i8, i16, and i64.

txgruppi avatar Feb 08 '22 16:02 txgruppi

u8 is also there, as an alias of byte. Yes, i32 and u8 should be the concrete types.

However, it might be useful to highlight type aliases differently from concrete types, because they do have different properties... such as being able to add your own custom methods to an alias, which you can't do with a concrete type.

JalonSolov avatar Feb 08 '22 16:02 JalonSolov

@JalonSolov I updated the PR to only include i32 in the numeric type list. Same place where u8 is defined. This should fix i32 being the different one.

image

txgruppi avatar Feb 08 '22 16:02 txgruppi

any news on this one?

txgruppi avatar Mar 07 '22 18:03 txgruppi

hello @txgruppi I recommend you talk about this on Discord https://discord.gg/2gnC8YK4qC There is no channel for vscode-vlang but for vls and ideas-suggestions... The whole team is here. so I think it will be the fastest way to reach a resolution

Sarctiann avatar Apr 29 '22 18:04 Sarctiann

u8 has been switched to the real type, with byte as an alias. Nothing has changed with i32 vs int, yet.

JalonSolov avatar Apr 29 '22 18:04 JalonSolov