v icon indicating copy to clipboard operation
v copied to clipboard

vlib.os: fix join-path

Open hholst80 opened this issue 1 year ago • 2 comments

Closes #20231

hholst80 avatar May 04 '24 22:05 hholst80

Since I'm mentioned as a co-author in the full diff, because the parts I tried to help with during development got squashed, I have to say it's not signed off by me.

I think it's honorable that you leave me in there, I thank you for that, @hholst80, but the way it's done might also distort the situation.

Now, aiming to keep things technical and to choose the solution that best serves the project, why not go with the suggestion in Spy's PR and have this one updated? Or what issues are there when doing it like this?

ttytm avatar May 05 '24 21:05 ttytm

Since I'm mentioned as a co-author in the full diff, because the parts I tried to help with during development got squashed, I have to say it's not signed off by me.

I think it's honorable that you leave me in there, I thank you for that, @hholst80, but the way it's done might also distort the situation.

Now, aiming to keep things technical and to choose the solution that best serves the project, why not go with the suggestion in Spy's PR and have this one updated? Or what issues are there when doing it like this?

I don't think that matter. I should add Spy as a co-author as well because I stole code from his PR but he already maxed out on street cred.

I think from a newcomers perspective that it is important that my PR takes precedence because I took my time to report an issue and then to understand what was the problem. For me this was an investment of time, not only now, but in the future because I 1) believe in V's future and and 2) see myself as part of that future.

Ultimately it is a team effort to get it done and a PR process is just an exercise an proving ground if the communication works does the developers listen and respect each other.

hholst80 avatar May 06 '24 09:05 hholst80