v icon indicating copy to clipboard operation
v copied to clipboard

fmt: fix striping modules prefix in orm

Open LouisSchmieder opened this issue 2 years ago • 4 comments

closes #14732

LouisSchmieder avatar Jul 10 '22 02:07 LouisSchmieder

Please add the failing (and now fixed) code snippet as a regression test file in say: vlib/v/fmt/tests/orm_module_prefix_keep.vv (the _keep.vv suffix is important, it means that file is checked to be invariant under vfmt (it will be processed by v fmt file.v, and the result should be exactly the same as the input)).

spytheman avatar Jul 10 '22 17:07 spytheman

Also

 FAIL  [ 92/187]     0.590 ms file vlib/v/fmt/tests/orm_keep.vv after formatting, does not look as expected.

medvednikov avatar Jul 11 '22 05:07 medvednikov

I'll look into it later

LouisSchmieder avatar Jul 11 '22 13:07 LouisSchmieder

Will continue this pr after the 1th August probably, bc of holidays

LouisSchmieder avatar Jul 22 '22 22:07 LouisSchmieder

@spytheman it is done now

LouisSchmieder avatar Aug 31 '22 09:08 LouisSchmieder