ngSemantic icon indicating copy to clipboard operation
ngSemantic copied to clipboard

Popup should use event.currentTarget

Open flemeur opened this issue 8 years ago • 2 comments

I'm experiencing an issue using the popup component. If I have a button with an icon inside and click on the icon the popup will use the icon as element for the popup instead of the button itself. This can be avoided by using event.currentTarget (https://github.com/vladotesanovic/ngSemantic/blob/master/src/popup/popup.ts#L31) which always points to the element the handler is attached to (the button), instead of the element that created the event (the button or the icon)

See: https://developer.mozilla.org/en-US/docs/Web/API/Event/currentTarget

flemeur avatar Feb 28 '17 13:02 flemeur

I would love to see a fix for this.

Ralla avatar Mar 01 '17 09:03 Ralla

+1 on this

marsdk avatar Mar 02 '17 13:03 marsdk