ngSemantic icon indicating copy to clipboard operation
ngSemantic copied to clipboard

issue #149: Added @NgModule declarations…

Open borisfeldmann opened this issue 8 years ago • 5 comments

…to prevent error "NgSemanticModule is not an NgModule"

borisfeldmann avatar Feb 10 '17 16:02 borisfeldmann

Can this be merged? I need it to build my site in a production environment.

Tzesar avatar Mar 12 '17 19:03 Tzesar

👍, I'm getting this error too

Failed to compile. NgSemanticModule is not an NgModule

dinever avatar Mar 24 '17 15:03 dinever

Hey @Tzesar, @sushanzh in your package.json use "ng-semantic": "https://github.com/borisfeldmann/ngSemantic/tarball/master" and replace the imports of NgSemanticModule from ng-semantic to "ng-semantic/ng-semantic"

AndreasZaschka avatar Apr 12 '17 10:04 AndreasZaschka

Is there a reason this change is not merged? I see it has been approved but still can't use this library in the current CLI environment as is. Thanks for the great library, hope to be able to use it soon in an NPM setting.

Edit: Is there a technical reason we can help resolve to be able to merge this in? :)

hookedupjoe avatar Apr 21 '17 21:04 hookedupjoe

@AndreasZaschka that's not relevant, the package.json file wasn't changed in this PR. please pull it in, it's been almost 3 months.

JSMike avatar Apr 29 '17 15:04 JSMike