go-test-coverage icon indicating copy to clipboard operation
go-test-coverage copied to clipboard

Moving from Golang 1.21.0 to 1.22.2 Test Coverage changes

Open frankjkelly opened this issue 8 months ago • 1 comments

For Golang 1.21.0 I get

make check-coverage-html
go install github.com/vladopajic/go-test-coverage/v2@latest
go: github.com/vladopajic/go-test-coverage/[email protected] requires go >= 1.22; switching to go1.22.4
.
.
/Users/fkelly/go/bin/go-test-coverage --config=./.testcoverage.yml
File coverage threshold (55%) satisfied:	PASS
Package coverage threshold (55%) satisfied:	PASS
Total coverage threshold (74%) satisfied:	PASS
Total test coverage: 75%

For Golang 1.22.2 I get

go install github.com/vladopajic/go-test-coverage/v2@latest
go: github.com/vladopajic/go-test-coverage/[email protected] requires go >= 1.22; switching to go1.22.4
.
.
/Users/fkelly/go/bin/go-test-coverage --config=./.testcoverage.yml
File coverage threshold (55%) satisfied:	FAIL
  below threshold:				coverage:	threshold:
  cmd/workflow_manager/main.go			0%		55%

Package coverage threshold (55%) satisfied:	FAIL
  below threshold:				coverage:	threshold:
  cmd/workflow_manager				0%		55%

Total coverage threshold (74%) satisfied:	FAIL
Total test coverage: 70%
make: *** [check-coverage] Error 1

Looks like files that were previously not being included are now included?

frankjkelly avatar Jun 18 '24 21:06 frankjkelly