hypersistence-utils icon indicating copy to clipboard operation
hypersistence-utils copied to clipboard

GitHub enhacements

Open piotrooo opened this issue 1 year ago • 3 comments

@vladmihalcea what do you think about couple GitHub enhancements like:

  • Add GitHub Action for run tests for each pull request. That let contributors feedback is everything OK with theirs changes.
  • Add GitHub Action for generating more readable change log, and try to use a Releases. I mean use for example release-drafter. That could be connected with using labels for PR's.
  • Add some tool to generate code coverage (JaCoCo and codecov)

piotrooo avatar Aug 12 '22 15:08 piotrooo

I'm now working on adding support for Test Containers that will make tests run by GitHub Actions.

As for the release-drafter, that will not work properly since there are commits done without a Pull Request.

JaCoCo is also nice to have, but not a priority at the moment.

vladmihalcea avatar Aug 12 '22 16:08 vladmihalcea

Using Pull Request can give a lot of feedback and could be treated as an additional documentation. There is any particular reason for that the commits are done without it? Maybe that could be reconsidered.

piotrooo avatar Aug 12 '22 17:08 piotrooo

Around 90% of all the work was done by me, so issuing a PR that I review myself and rebase afterward would have been a waste of time.

PRs are fine for external committers, but even then, I don't always integrate them directly. Sometimes, I have to get their commit and rework it before I push the amended commit. GitHub will not view that as a merge since I'm rebasing an amended commit.

The current changelog is sufficient as this is a very small project that doesn't get a lot of changes.

vladmihalcea avatar Aug 12 '22 18:08 vladmihalcea