wpgp-tools
wpgp-tools copied to clipboard
vlad-timotei
Prevent save on any saving workflow
I have everything on "Warn & prevent save" in the options menu... Yet, if I save a string that doesn't have a . , ? , ! at the end and I save it with one... The tool doesn't stop me anymore. It does give a warning after saving, but it doesn't prevent.
Update: it might be a conflict with GlotDict. Disabling that, it stops me when I add an "." at the end. But not when I add any other punctuation marks. Gonna test further.
In testing, it's the shortcut CTRL+Enter that is skipping the check. @vlad-timotei and I confirmed this in Slack DM's.
GlotDict is not the culpirt, but it introduces a new saving shortcut that WPGPT doesn't catch: Ctrl+Enter
-snip-
But, I noticed something else. When you approve the string using WP Translation Filler, the string gets accepted (goes green) but doesn't go current since I assume it gets blocked by this add-on?
Thanks for investigating. So, on one hand, we have GD that can save despite WPGPT warning using the keyboard shortcut flow and that should not happen - it's a problem on WPGPT's side. Currently investigating possible technical solutions.
On the other hand we have TF that is not able to save strings with WPGPT warnings using its custom buttons, and I find that correct. Users of WPGPT should be prevented to save strings with warnings in any scenario.
However if TF needs to overrule WPGPT warnings, it can - calling GP native functions directly, not by triggring the Save button that is guarded by WPGPT checks.
So, the main issue stands. Work in progress. :)
TF becomes green if it does not find problems regarding the usage of Glossary verbs. The fact that WPGPT blocks saving, has a different reason. I do not think overuling WPGPT would be wyse. TF does not block bad translations, it only signals that fact.
