calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Svelte 5 support

Open geoextra opened this issue 1 year ago • 7 comments

When using the Calendar component in a Svelte 5 project it relies on get_current_component() from svelte/internal which has been removed. https://github.com/vkurko/calendar/blob/d337436bfebf7ddac21b1d787d5300f44744ef4d/packages/core/src/Calendar.svelte#L4

A possible solution is presented here with an example.

Tested with Svelte 5.0.0-next.50.

geoextra avatar Feb 07 '24 09:02 geoextra

Thanks for the tip. Svelte 5 support will definitely come in the future.

vkurko avatar Feb 07 '24 09:02 vkurko

This is not only place with svelte/internal there is like 100 more places unfortunately

bayaderpack avatar Apr 27 '24 10:04 bayaderpack

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

dummdidumm avatar Apr 27 '24 12:04 dummdidumm

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

Author of Event Calendar here :smiley:. @dummdidumm Thanks for the intervention. I would like to inform you that at the moment the migration to Svelte 5 has not yet been carried out.

The reason for using svelte/internal is that there are really useful functions there that will already be present in the final code, so it makes sense to reuse them in my library rather than write my own code. And for example get_current_component() it is impossible to write my own analogue.

vkurko avatar Apr 28 '24 17:04 vkurko

Hello @vkurko, do you have a date in mind for svelte 5 support or not yet ? Thanks

HoekWax avatar Jun 01 '24 23:06 HoekWax

Not yet, unfortunately. Any help in this matter, including sponsorship, is welcome.

vkurko avatar Jun 03 '24 06:06 vkurko

I love this project hoping for svelte 5 support!

itsmikesharescode avatar Aug 23 '24 17:08 itsmikesharescode