Vinzent Steinberg

I'm getting the expected results for `geo.query_geonames('California')`, but `geo.query_geonames_country('California', 'USA')` returns no results. Am I missing something?

document the purpose of associated data

10

Right now it is not clear what purpose the associated data serves. It would be great if it could be documented.

Document how to install missing package files

5

In forum the following is suggested: > Copy the package files into the directory containing your document > > This is the simplest answer, in a certain sense. If a...

Currently there is no documentation for `secure_memest`. I assume it takes care not to get optimized away? Please clarify this in the documentation.

Use of predictable RNG

13

This library recently switched to non-CSPRNGs (see #141 and #162), which are inherently predictable based on observations of their output. Doesn't this make the library vulnerable to attacks listed [here](https://owasp.org/www-community/vulnerabilities/Insecure_Temporary_File),...

Rust version compatibility of features

2

The README specifies that Rust 1.15 is supported. However, Rand 0.5 requires at least 1.22, so at least the `rand` features does break the promise from the README. Are non-default...

Implement more number theory functions

11

This implements the extended Euclidean algorithm, the modular inverse and modular exponentiation. * This is taken from https://github.com/vks/discrete-log and uses the traits from `num-traits`. * To avoid break backwards compatibility,...

Double-check pow implementation on MIPS

1

In Rand, we use essentially the same implementation as in in `num_traits`, but it fails to return the correct result on the MIPS architecture: https://github.com/rust-random/rand/pull/752 It seems likely that the...

Variance and mean could be calculated in a better way

1

Currently the mean is calculated in a very naive way, which has numerical problems. Also it is possible to calculate the variance (and higher moments) in a single pass over...