average icon indicating copy to clipboard operation
average copied to clipboard

Find some way for serde to fail to deserialize inputs that break invariants

Open vks opened this issue 5 years ago • 1 comments

Deserializing does not currently check for all invalid inputs. Also see #6 and #7.

vks avatar Jul 27 '18 14:07 vks

Here is some official advice for how this could be done:

use serde::{de, Deserialize, Deserializer};

#[derive(Deserialize, Debug)]
#[serde(remote = "Self")]
struct Invariant {
    /// len() >= 3
    s: String,
}

impl<'de> Deserialize<'de> for Invariant {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        let unchecked = Invariant::deserialize(deserializer)?;
        if unchecked.s.len() < 3 {
            return Err(de::Error::custom("length of `s` must be >= 3"));
        }
        Ok(unchecked)
    }
}

fn main() {
    let j = r#" {"s": "abc"} "#;
    println!("{:?}", serde_json::from_str::<Invariant>(j).unwrap());
}

vks avatar Apr 30 '21 00:04 vks