Vadim Kononov

Results 26 comments of Vadim Kononov

> @piotrmurach Is there anything we can do to get this merged and make this lib compatible with Ruby 3.1+. Happy to help in any way possible @abhishekjain16 You could...

Thank you, @abhishekjain16. Can't believe I missed that. @piotrmurach, Could you run the pipeline and merge this code if the pipeline succeeds?

@nctruong This pull request is missing corresponding documentation within `README.md` and needs automated tests.

I was able to fix this issue for 3.5.3 without patching `node_modules`. I used the [react-native-permissions](https://www.npmjs.com/package/react-native-permissions) library to ask for the missing `WRITE_EXTERNAL_STORAGE` permission. Here's some sample code for Android:...

> I doubt that you tested this on an Android 13 device. This issue is about running on an Android 13 device and this Android version does not grant WRITE_EXTERNAL_STORAGE...

There is now a `generate_appearance` optional parameter for the `set_field` and `set_fields` methods that partially addresses this problem.