Add SSL support

[skwashd]

Adds initial support for SSL. The implementation supports the following features:

• Remote certificate validation
• Custom CA bundles
• Client side certs

SSL is now on by default.

Fixes vklochan/python-logstash#28

[vellamike]

Is this feature ready to be merged in? Would be very useful.

[vellamike]

Am I correct in assuming that this PR adds support for the lumberjack protocol?

[skwashd]

@vellamike the library already implements the logstash json over HTTP protocol. This patch adds HTTPS support to the transport component.

[vellamike]

@skwashd my understanding is that the communication here is done over TCP, with no HTTP layer, and that logstash itself supports a custom TCP-like protocol called lumberjack which there is no python support for (though it is supported in node)

[dickolsson]

Code looks good. Fairly simple changes for such a major feature addition.

I would love for this to get merged. It's something we really need for a project.

[skwashd]

@vellamike sorry you're right it is over TCP (now with optional SSL support).

[skwashd]

@vklochan I've rebased current master into the patch. Is there anything else I need to do in order to get this merged?

[brenoarosa]

Can we have any update in this PR? This package does an amazing job for me but I need the SSL suport to use it.

[marji]

Could we please get this merged? It would be very useful.

[kramarz]

Can you make it compatible with python3? it complains that makeSocket does not accepts any arguments. Change:

def makeSocket(self, timeout=1):
        s = super(TCPLogstashHandler, self).makeSocket(timeout)

To:

def makeSocket(self, *args, **kwargs):
        s = super(TCPLogstashHandler, self).makeSocket(*args, **kwargs)

[skwashd]

@vklochan is there any thing I can do to help get this merged? Do you need a comaintainer to assist with cleaning up the backlog of issues and PRs?

[SalahAdDin]

@skwashd Finally, what did you do?