CSharpFunctionalExtensions icon indicating copy to clipboard operation
CSharpFunctionalExtensions copied to clipboard

Strong Name

Open ResiEvil opened this issue 7 years ago • 8 comments

Is it possible to strong name the assemblies?

Many Thanks

ResiEvil avatar Apr 12 '17 14:04 ResiEvil

I would prefer not to strong name the package. Could this help it your situation: https://github.com/dsplaisted/strongnamer ?

vkhorikov avatar Apr 17 '17 21:04 vkhorikov

Worked like a charm and solved the problem for me. Thank you very much!

Ironbell avatar Apr 09 '18 08:04 Ironbell

What is the reason why you don't want to sign the assembly? It is not very convenient to use two NuGet packages (yours and StrongNamer) instead of one.

yakimovim avatar Jul 24 '19 13:07 yakimovim

It's mostly a relic from the older MS days: https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/strong-name-signing.md#1-microsoft-strong-names-their-assemblies-should-i

vkhorikov avatar Jul 30 '19 01:07 vkhorikov

StrongNamer is causing great issues. In my situation, the only way to use your library is when it's signed. Thanks

rizksobhi avatar Feb 15 '21 17:02 rizksobhi

I plan to release a signed version of the library, similar to how Dapper does it. But I don't have an ETA yet unfortunately.

vkhorikov avatar Feb 16 '21 15:02 vkhorikov

Vladimir, I don't find your reasoning for non-signing strong enough, but more like a personal flavor on your side. I would prefer working with a strong name assembly every day as this gives some assurance that nobody tampered with the existing implementation, as it will require the original key to sign it. In most companies, there are policies in place that will require this one, together with a digital signature (signtool.exe).

The community should have priority in detriment of flavors.

Having the key in is actually a minimal effort, compared with the possibility of searching for a drop-in replacement for any unsigned library, unbundling the existing package and signing it internally, or using some kind of unsecure NuGet that will do the signature for you.

I would like to see it in the very next release if possible.

adcorduneanu avatar Sep 24 '22 10:09 adcorduneanu

Well, I did change my opinion, see my last comment.

vkhorikov avatar Sep 26 '22 13:09 vkhorikov

Hey @vkhorikov, I have created a PR (#543) to address this issue. Please let me know if you're happy with this solution. I'm not sure if anything is needed for nuget.org to accept a new package with the same prefix.

bothzoli avatar May 23 '24 02:05 bothzoli

Fantastic work, thanks @bothzoli . This is probably the longest standing unresolved request for this library.

vkhorikov avatar Jun 23 '24 13:06 vkhorikov