hugo-theme-casper icon indicating copy to clipboard operation
hugo-theme-casper copied to clipboard

v0.55 .URL deprecated,.RSSLink deprecated,use hugo global function

Open nonumeros opened this issue 5 years ago • 6 comments

nonumeros avatar Apr 14 '19 13:04 nonumeros

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

halink0803 avatar Oct 18 '19 08:10 halink0803

Actually, the problem is only with the navigation.html file, as the .Menu.URL is not deprecated. Only .Page.URL is deprecated.

halink0803 avatar Oct 18 '19 15:10 halink0803

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with

if a site is created from scratch with 0.55,it works for me.

nonumeros avatar Oct 18 '19 16:10 nonumeros

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with

if a site is created from scratch with 0.55,it works for me.

I tried with 0.55 and even update to 0.58, it is failed if you change .URL in navigation .Menu.URL.

halink0803 avatar Oct 19 '19 23:10 halink0803

Did you tried to build a page with your changes? I tried but it failed with error:

Failed to render pages: render of "home" failed: "src/themes/casper/layouts/page/index.html:12:24": execute of template failed: template: page/index.html:1:3: executing "page/index.html" at <partial "header.html" .>: error calling partial: "/src/themes/casper/layouts/partials/header.html:12:24": execute of template failed: template: partials/header.html:123:5: executing "partials/header.html" at <partial "navigation.html" .>: error calling partial: "/src/themes/casper/layouts/partials/navigation.html:12:24": execute of template failed: template: partials/navigation.html:12:24: executing "partials/navigation.html" at <.Permalink>: can't evaluate field Permalink in type *navigation.MenuEntry

It seems this PR does not work.

what hugo version did you run it with if a site is created from scratch with 0.55,it works for me.

I tried with 0.55 and even update to 0.58, it is failed if you change .URL in navigation .Menu.URL.

@halink0803 thanks for bringing it up.. it did flew over my head and it reminded me of a similar issue with another repo.. Thanks again!

nonumeros avatar Oct 21 '19 16:10 nonumeros

@vjeantet are you still maintaining this theme? I'm just wondering because the last merge was done on 2018. There're quite a few outstanding issues that have come up ever since.

nonumeros avatar Dec 30 '19 04:12 nonumeros