vizhub-issue-tracker icon indicating copy to clipboard operation
vizhub-issue-tracker copied to clipboard

Published 20 hours ago • verified publisher icon vizhub-core

Fork count seems wrong

Open nitanagdeote opened this issue 4 years ago • 2 comments

On map viz the fork count seems wrong for this user( image attached) wrong_no_of_forks_on_map_viz

nitanagdeote avatar Feb 08 '21 21:02 nitanagdeote

My first thought is, private forks are included in the count, but not in the listing.

Also there is a chance that the data could be wrong (the way we backfilled those values was a bit ... sketchy - could do it again).

Idea: Include something in the forks page that says how many private forks there are, but not include any info on who forked them.

curran avatar Feb 09 '21 15:02 curran

The issue is that the forks count includes private forks.

Should it?

Maybe it should only show the number of public forks?

I wonder what GitHub does...

If it shows the total that includes private forks, then the existence of those forks is not actually ... private. In a way this is leaking out private information (the fact that the viz was forked at all).

curran avatar May 15 '21 21:05 curran