vizhub-issue-tracker Link to Line Number

Link to Line Number - scroll line to middle

Open curran opened this issue 5 years ago • 2 comments

Try this link:

It seems a bit off that the line is at the very bottom. Ideally it should scroll to the middle.

This snippet may be useful for achieving this: https://gist.github.com/marijnh/3632766

Jun 14 '20 15:06 curran

@curran check out this thread https://d3js.slack.com/archives/G015H8H66H2/p1605290900168800?thread_ts=1605289226.167500&cid=G015H8H66H2

I implemented this behavior and it was deployed to staging. Is this issue still relevant?

Nov 21 '20 17:11 stushurik

@stushurik I just tested this on staging and it scrolls to the top it seems. Maybe it was working and broke at some point?

Reproduction: https://staging.vizhub.com/sarakouz/7b2cc5e0ccf5467582ce73c8ab7ff819?edit=files&file=index.js&line#L34

Nov 22 '20 12:11 curran