viz icon indicating copy to clipboard operation
viz copied to clipboard

Graceful shutdown hangs when I use a Chromium based browser

Open czy-29 opened this issue 9 months ago • 1 comments

This problem of Viz is exactly the same as Axum: https://github.com/tokio-rs/axum/issues/2611

This is due to a bug in hyper-util: issue: https://github.com/hyperium/hyper/issues/3576 pr: https://github.com/hyperium/hyper-util/pull/101

Patching hyper-util in Cargo.toml like this also works for viz:

[patch.crates-io]
hyper-util = { git = "https://github.com/hyperium/hyper-util.git", rev = "a77d866ff65a68ea5d048d058108552c39ec470d" }

The reason for posting the same issue here in Viz is that when hyper-util is finally updated, I hope we can follow up with the updated version in time, so that I can remove such a temporary patch and update to the latest version.

czy-29 avatar May 09 '24 06:05 czy-29

Thanks for the feedback. I will fix this ASAP.

fundon avatar May 11 '24 16:05 fundon

hyper-util 0.1.4 is released! https://crates.io/crates/hyper-util/0.1.4 We should update as soon as possible and finally close this issue.

czy-29 avatar May 26 '24 06:05 czy-29

Nice! Let's ship it.

fundon avatar May 26 '24 10:05 fundon

Landed in v0.8.5. Thanks.

fundon avatar May 28 '24 03:05 fundon