react-native-ble-advertiser icon indicating copy to clipboard operation
react-native-ble-advertiser copied to clipboard

BUG scanByService failed

Open Dorbmon opened this issue 2 years ago • 0 comments

in BLEAdvertiserModule.java, We have code :

if (manufacturerPayload == null)
            filters = null;
if (manufacturerPayload != null)
            filters.add(new ScanFilter.Builder().setManufacturerData(companyId, toByteArray(manufacturerPayload)).build());
if (uid != null) 
            filters.add(new ScanFilter.Builder().setServiceUuid(ParcelUuid.fromString(uid)).build());

And in

public void scanByService(String uid, ReadableMap options, Promise promise) {
        scan(uid, null, options, promise);
}

The manufacturerPayload is passed as null, this will cause filters to be null and filters.add(new ScanFilter.Builder().setServiceUuid(ParcelUuid.fromString(uid)).build()); will still run causing a runtime error of invalid address visit.

Dorbmon avatar Feb 19 '23 09:02 Dorbmon