amethyst icon indicating copy to clipboard operation
amethyst copied to clipboard

[FEATURE] options/features/language switcher

Open chiajlingvoj opened this issue 1 year ago • 11 comments

I think it would be great to have a way to adjust options/preferences/other settings within Amethyst. For example, the UI language right now always follows the system settings and there is no way to set a different one other than changing system language. The problem becomes: what if the user wants to use a different one, or the desired one is not available as a system language choice?

The options panel could also be a place to adjust other settings that other feature requests have raised such as filtering/visibility/etc.

Alternatively regarding lang choice: I know that in Android 13 (and possibly earlier?) it is possible to change UI language on a per-app basis, but I guess it has to be enabled somehow within the app?

I'd be happy to put a 50k bounty on this!

chiajlingvoj avatar Mar 21 '23 02:03 chiajlingvoj

Would like to tackle this. Please @vitorpamplona any preferred UI/UX suggestions?

KotlinGeekDev avatar May 17 '23 14:05 KotlinGeekDev

related to #394

chiajlingvoj avatar May 24 '23 18:05 chiajlingvoj

So want to minimize options as much as possible. That being said, @3j2009 has some good UIs here: https://github.com/vitorpamplona/amethyst/issues/394

The only question is: are these per account or one for all accounts? And how do we make that clear in the UI?

vitorpamplona avatar May 24 '23 21:05 vitorpamplona

@vitorpamplona I thought of 3 options.

  1. Per the UI mock-up on the option in the settings screen, we can just clarify it in the small text for the option. Something like:

    Post editing

    Edit your posts up to 30s after editing. Limited to this account.

  2. We can make it a section called Post editing, and inside, have different toggles.
  3. We can make a tri-state toggle, with options, Off, One(For the current account), All(for all accounts)
    Oops, wrong post.

KotlinGeekDev avatar May 24 '23 22:05 KotlinGeekDev

@vitorpamplona we can have a dropdown menu with the languages, and a dual-state toggle beneath it to choose applying to one account or all accounts.

KotlinGeekDev avatar May 24 '23 22:05 KotlinGeekDev

Android 13 allows per-App language preferences in System settings (App needs to support it though).

Would implementing this be worth the effort considering the small market share of android 13?

davotoula avatar May 29 '23 20:05 davotoula

That really is the question.

KotlinGeekDev avatar May 29 '23 21:05 KotlinGeekDev

I'll have a look at this. If it doesn't complicate the base code it could be a nice ux enhancement

davotoula avatar May 30 '23 11:05 davotoula

Hmm @vitorpamplona @davotoula the only thing remaining here is app-wide or per-account language settings. Cc @chiajlingvoj @greenart7c3

KotlinGeekDev avatar Jul 28 '23 15:07 KotlinGeekDev

I just realised that the burger menu has a mix of account specific and global settings.

Maybe all global settings should be inside a "Global settings" menu item?

davotoula avatar Jul 28 '23 20:07 davotoula

I wonder how the UI/UX will be like.

KotlinGeekDev avatar Jul 28 '23 21:07 KotlinGeekDev

@vitorpamplona I think this issue can be closed. @davotoula I guess the global settings menu may be part of the settings re-arrangement mentioned in #734 ?

KotlinGeekDev avatar May 30 '24 15:05 KotlinGeekDev

Maybe all global settings should be inside a "Global settings" menu item?

There will be Account-based Settings and App-based Settings. We just need to make it clear on the UI which one is which.

vitorpamplona avatar May 30 '24 15:05 vitorpamplona

Yes, I agree that it can be closed

May 30, 2024 11:33:48 AM KotlinGeekDev @.***>:

@vitorpamplona[https://github.com/vitorpamplona] I think this issue can be closed. @davotoula[https://github.com/davotoula] I guess the global settings menu may be part of the settings re-arrangement mentioned in #734[https://github.com/vitorpamplona/amethyst/issues/734] ?

— Reply to this email directly, view it on GitHub[https://github.com/vitorpamplona/amethyst/issues/298#issuecomment-2139963495], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ALYJUORTWHY57CSSAY6LSPTZE5BFVAVCNFSM6AAAAAAWB3CEUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZHE3DGNBZGU]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/ALYJUOUNKXYSKXJAVSP5R4DZE5BFVA5CNFSM6AAAAAAWB3CEUGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7RVAGO.gif]

chiajlingvoj avatar May 30 '24 15:05 chiajlingvoj