amethyst icon indicating copy to clipboard operation
amethyst copied to clipboard

[FEATURE] Split notifications view for following and everyone else.

Open niteshbalusu11 opened this issue 1 year ago • 21 comments

Is your feature request related to a problem? Please describe.

The notification icon glows for every little event on your post. It can get a little overwhelming at times to keep looking at it as your number of followers grow.

Describe the solution you'd like

A separate view for notifications for activity from people you follow and everyone else and make the icon glow only for people you follow. Sort of similar to DMs. This can be a opt-in setting instead of being default.

Bounty (in Bitcoin sats) offered for the implementation

50K sats.

niteshbalusu11 avatar Mar 04 '23 21:03 niteshbalusu11

Something like this? @niteshbalusu11

#197

3j2009 avatar Mar 05 '23 01:03 3j2009

@3j2009 yep! We could take this further with what actually shows up in notifications like you just want comments and reposts and no zaps and likes but that could be a separate feature request. This looks good to me! Also, just to make sure I ideally want the notification to light up only for following (as an opt-in setting).

niteshbalusu11 avatar Mar 05 '23 01:03 niteshbalusu11

Some prototypes here. I can provide whichever files needed if the design receives approval for dev.

What's in the screens:

  • Notifications split into Following / All so user has to option to quickly see notifications only from the accounts they follow (assuming those accounts are the most important accounts to the user)
  • Cog icon (notification settings) brings up the toggle settings for filtering notification types.

#197-1

#197-2

#197-3

3j2009 avatar Mar 05 '23 02:03 3j2009

Interesting discussion. I don't know if people want to choose which type of notification they want to see, but i do know there are 3 levels of notifications:

  • Everything from Follows only
  • Everything that directly cites you (default today) and that replies directly to a post authored by you.
  • Everything that mentions you anywhere in the thread, including likes, zaps, boosts on replies to your posts, or replies of your replies, that were not authored by you but you are in the reply list.

vitorpamplona avatar Mar 05 '23 02:03 vitorpamplona

Interesting discussion. I don't know if people want to choose which type of notification they want to see, but i do know there are 3 levels of notifications:

  • Everything from Follows only
  • Everything that directly cites you (default today) and that replies directly to a post authored by you.
  • Everything that mentions you anywhere in the thread, including likes, zaps, boosts on replies to your posts, or replies of your posts, that were not authored by you but you are in the reply list.

I do like the settings page mock up that @3j2009 put together, gives really nice control. However I'm not fully aware of how data is stored on relays for each event and how easy it is to filter for each of them when showing in the notifications pane. That is probably your expertise @vitorpamplona Especially likes are a little too much for notifications imo.

niteshbalusu11 avatar Mar 05 '23 02:03 niteshbalusu11

Personally, I'm only interested in receiving notifications for Comments (on my posts), Zaps and Mentions. But I imagine everyone has their own preferences. Without large scale data it's one opinion against another as to which notifications people want control over, but providing the user with the ability to choose is likely to garner more support than withholding the ability to choose.

3j2009 avatar Mar 05 '23 03:03 3j2009

I like this idea a lot, whatever granularity is available should be exposed for user configuration (within reason). I would also add that notifications should probably not show whole notes or things like inline previews (images, URL cards, etc), full text on posts more than a line or two, or all of the reaction buttons. I think those things should stay in the note detail view, so you would just tap the notification to take some action.

I would prefer if notifications took up a lot less space on the screen so I could tell at a glance what it was about and then tap in if I wanted to interact with the note or thread.

maxmoney21m avatar Mar 05 '23 03:03 maxmoney21m

I agree. 💯

niteshbalusu11 avatar Mar 05 '23 03:03 niteshbalusu11

I like the idea not to show whole notes in notifications @maxmoney21m

How I'm imagining the ideas in this discussion.

  • Notifications separated into "following" and "all" categories
  • When multiple accounts are involved in the same action on the same post, the notification is limited to 3 names "and others"
  • Replies to your post are limited to 3 lines, with "see more" giving option to expand the reply inside the notifications screen.
  • Referenced posts (your post) is limited to 2 lines and boxed in grey with your avatar 1/2 size for quick muscle memory that it's your post.
  • Removed the "replying to" which exists in current build as it's unnecessary information to contain in the notifications preview when an account is reacting to a reply comment you made on another account's post. Now only shows Account;Action;Post / Satoshi;Zapped;Your reply comment on another account's post.

#197-4

3j2009 avatar Mar 05 '23 04:03 3j2009

@3j2009 this looks great IMO. 2 minor suggestions:

  • No need for a "see more" button that expands inline, just the ... and tap it to go into the note detail view would suffice, IMO
  • The "X Y Z and others" could say how many, since I think we should have the count easily enough. "X Y Z and 12 others liked your note"

And very minor grammar error for whoever ends up coding this, remove this "to": "liked/boosted ~~to~~ your note"

maxmoney21m avatar Mar 05 '23 18:03 maxmoney21m

The only item left is how to render multiple replies to the same post without copying the post itself all the time.

vitorpamplona avatar Mar 05 '23 18:03 vitorpamplona

@maxmoney21m thanks for the great feedback and nice catch on the grammar error. @vitorpamplona I've proposed a fix for rendering multiple replies

Below screens show the updated prototype.

The following proposed changes to prior prototypes are:

  • Removed "see more" button and kept "..." to serve as button to expand text
  • "..." text expansion button now White to separate itself visually from the quoted text comment.
  • Total number of accounts in an action now displayed; e.g. "Nitesh, Max, 3j2009 and 42 others liked your note:"
  • Multiple replies to the same post now rendered without copying the note original itself each time. User can tap arrow button area to see all replies, and, tap again the area to collapse all replies. {Arrow button area is an invisible rectangle surrounding the arrow & line bracket button}
  • Avatars of accounts that replied to your note are 1/2 size when multiple replies are on the note
  • Replies bracket button color is default grey when collapsed or active purple when expanded. This helps the user to quickly visually track which text is contained in the replies for that note and shows the replies bracket button as active.
  • Settings icon removed from top right of screen (Removed from this user story as there's already many tasks for this story. Notification settings can be discussed in another user story)

#197-5 #197-6 #197-7

3j2009 avatar Mar 06 '23 01:03 3j2009

Damn! So quick at mocking up @3j2009

niteshbalusu11 avatar Mar 06 '23 02:03 niteshbalusu11

Question: how would this work if there are 100 replies? What about if there are some replies in a short period and another one or multiple replies later?

maxmoney21m avatar Mar 06 '23 03:03 maxmoney21m

Question: how would this work if there are 100 replies? What about if there are some replies in a short period and another one or multiple replies later?

Those are good points, I was thinking about these too.

I think replies should be grouped based on elapsed time since the OP's note was created. Maybe start in 24h intervals and iterate if necessary - iteration on time interval grouping shouldn't be too code heavy in terms of changes.

If there's 50 or 100 replies in the 1 interval (e.g. first 24hours since the original note was posted) i think that's OK. Whilst there is the potential for massive scrolling in the notifications dashboard if the user chooses to be looking at all the replies, I imagine most users will collapse the reply bracket after 1or 2 page scrolls which is about 10 replies depending on the users screen resolution. Keep in mind also that if the user is in the "Following" section it would only show them replies from accounts the user follows.

3j2009 avatar Mar 06 '23 03:03 3j2009

Further to that, we could consider displaying the most recent replies first. This would ensure the user sees the newest replies first when viewing the reply bracket.

Interested to hear your thoughts @maxmoney21m

3j2009 avatar Mar 06 '23 04:03 3j2009

Bit hard to imagine how it would feel to use just looking at the images. I can imagine that personally I would probably rather just tap the note and go into the note detail view to see the replies on that screen, rather than trying to read them all on the notifications screen. I wonder if it's better to just remove the expand/collapse functionality, limit to some reasonable number of inline replies (e.g. 3 or 5 most recent ones), and then just expect the user to tap on the note to go to the detail view.

It seems the collapse/expand provides just another way to do what tapping into the note already does, but with an overall not as good UX since you can't comment or reply inline on the notifications page with these changes (which is good and should not be changed). So tapping the note to see everything makes the most sense to me.

The timed groupings might make sense. Probably need to more frequently than once every 24 hours, since notifications can easily get lost after just a few minutes or an hour. So if you had received a reply you get the notification, then a few more unrelated notifications come in, then after a few minutes you get another reply, now your notifications shows both replies in the same box, at the top of the notifications feed? Not sure I understood it correctly.

maxmoney21m avatar Mar 06 '23 07:03 maxmoney21m

I agree with you on the above.

Check out the flow below and let me know what you think (note the clock's time on the following screens)

(Figma prototype here)

or quick view using in the image flow below:

#197-8

3j2009 avatar Mar 07 '23 05:03 3j2009

Cool, seems like that would work pretty well. I like it.

maxmoney21m avatar Mar 07 '23 08:03 maxmoney21m

@vitorpamplona interested to hear your thoughts on the proposed updates to the notifications feed :)

3j2009 avatar Mar 08 '23 02:03 3j2009

Notifications now offer a List choice (Global, Follows or any NIP51 list). This should solve the original issue, but I will leave this open to work on the filter by Type UI.

vitorpamplona avatar May 11 '23 13:05 vitorpamplona