wineskin icon indicating copy to clipboard operation
wineskin copied to clipboard

mainRun not functional due to startExeLine.trim

Open Gcenx opened this issue 4 years ago • 0 comments

https://github.com/vitor251093/wineskin/blob/a6421583a641edb76d415067a9c4d2bd4876ae05/WineskinLauncher/WineskinLauncherAppDelegate.m#L2373-L2374

Currently this doesn't work as expected so for testing I'm doing the following;

            NSMutableArray* flags = [NSMutableArray array];
            //TODO: Find a better way to handle this
            if ([wineStartInfo isRunWithStartExe])
            {
                startExeLine = @"start";
                [flags addObject:startExeLine];
            }
            [flags addObject:[wineStartInfo getWineRunFile]];
            [flags addObject:[wineStartInfo getProgramFlags]];

While doing the above does function, however if an executable has any spaces within its name it will fail to launch.

~Edit; Also launch flags don't work~

~Edit2: I've edited the above it now launches executabled and uses flags correctly, if the executable contains spaces it still fails to launch~

Edit3: Edited the code again, now it works but seems the gecko issue might be caused by some other issue as some launches now cause programs to crash out

Gcenx avatar Jan 04 '20 03:01 Gcenx