Support node labels

[sananguliyev]

Firstly, thanks a lot for the nice project! Is there any plan to support custom label or annotations for servers, since it's very useful for separating the deployments between nodes. There are a bunch of default labels like instance type, location, hostname but sometime devs need to have some custom labels, too.

[Privatecoder]

Does this need to happen during deployment? I add additional labels and taints aftrewards.

[vitobotta]

Hi @sananguliyev, the tool doesn't add any labels to the nodes. What kind of labels where you thinking?

[sananguliyev]

Thanks for your answer. Let's assume that I am using the same type of servers for 2 different purposes.

1. API gateway
2. SQL Engine

It's very useful to add labels to nodes so when I deploy my gateway I can specify in my k8s deployment that run this app only on the nodes which has labelled api-gateway.

Edit: I am talking about nodeAffinity

[vitobotta]

I understand. However I think this goes beyond the scope of the tool which is creating clusters with a common configuration. What you are asking is for specific use cases. Would you want to add the same labels on all the nodes in a pool or how?

[sananguliyev]

Yes, exactly. I would like to have those labels on all nodes in the pool, otherwise it would be too specific.

Desired configuration:

worker_node_pools:
- name: sql-engine-small
  instance_type: cpx21
  instance_count: 3
  labels: 
    purpose: sql-engine
    size: small

[vitobotta]

Ok, I'll see what I can do.

[sananguliyev]

Perfect. Thanks in advance.

[Privatecoder]

@vitobotta if you add this you can also go ahead and add the same for taints, i.e.

worker_node_pools:
- name: sql-engine-small
  instance_type: cpx21
  instance_count: 3
  labels: 
    purpose: sql-engine
    size: small
  taints: 
    key: value

Would be more consistent ;)

[vitobotta]

Ok

[vitobotta]

Implemented in v0.6.2. Please give it a try and let me know how it goes.