vitest icon indicating copy to clipboard operation
vitest copied to clipboard

docs: remove falsy comment on test execution speed

Open christian-bromann opened this issue 6 months ago • 3 comments

Description

This PR removes a wrong statement from the docs that WebdriverIO doesn't support parallel tests and is slower than PW. Both statements are wrong. You can run as many parallel browser sessions as your system allows you. Furthermore, WebdriverIO is mostly relying on WebDriver Bidi these days which is the same communication method than CDP is using. You may technically argue that WebDriver Bidi messages go through a browser driver which is another hop and can potentially be slower than sending a socket message directly to the browser but I would argue that this doesn't impact test execution time a lot and I would love to see someone challenging this.

On contrary I can put in a statement saying that Playwright browser are not real browser used by users in the real world given they are patched to accomodate Playwrights proprietary automation approach.

I think generally we should stay away from making judgements about what is better for the user to use.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [x] Run the tests with pnpm test:ci.

Documentation

  • [x] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

christian-bromann avatar May 15 '25 15:05 christian-bromann

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
Latest commit 46e642979f88838c94b3ac461424e040fa192534
Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/682608445bcd3e00089919af
Deploy Preview https://deploy-preview-7982--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 15 '25 15:05 netlify[bot]

The statement is correct in the context of browser mode. Browser mode with the webdriverio provider doesn't support parallel execution, and it does run slower than PW because of how Vitest implements this support.

sheremet-va avatar May 15 '25 15:05 sheremet-va

Thank you for the additional context. Let me add some enhancements to the provider then.

christian-bromann avatar May 15 '25 16:05 christian-bromann