vitest icon indicating copy to clipboard operation
vitest copied to clipboard

chore(deps) test jsdom 27 beta

Open hi-ogawa opened this issue 7 months ago • 3 comments

Description

Related https://github.com/vitest-dev/vitest/discussions/7861

Just checking if any breaking change on Vitest environment level

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [ ] Run the tests with pnpm test:ci.

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa avatar Apr 20 '25 04:04 hi-ogawa

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
Latest commit 3c56716fab330ae433bf21c4766eff43ce09a8dd
Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/68047a6b4beb090008b92fe1
Deploy Preview https://deploy-preview-7863--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 20 '25 04:04 netlify[bot]

Thanks for testing. Let us know if there's anything we can do to help on the jsdom side. https://github.com/jsdom/jsdom/issues/3864

asamuzaK avatar May 05 '25 10:05 asamuzaK

@asamuzaK Thanks for ping! v27 looks fine on Vitest repo though we don't have a many jsdom test case internally, so this is mostly to confirm basic Vitest environment usage. Also note that Vitest's peerDependencies doesn't pin jsdom version, so Vitest users are free to upgrade jsdom on their own anytime. This PR is only for devDependencies of this repo.

Once jsdom v27 becomes latest tag, renovate will probably raise a PR, so that's when we'll merge it for own repo.

hi-ogawa avatar May 06 '25 00:05 hi-ogawa

We now support it with https://github.com/vitest-dev/vitest/pull/8700

sheremet-va avatar Nov 06 '25 14:11 sheremet-va