vitest icon indicating copy to clipboard operation
vitest copied to clipboard

fix: correctly report "skipped" result in TestCase

Open sheremet-va opened this issue 11 months ago • 2 comments

Description

I'm also wondering if we should remove the skipped state altogether from the result() and only keep pass and fail 🤔

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [ ] Run the tests with pnpm test:ci.

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

sheremet-va avatar Dec 11 '24 09:12 sheremet-va

Deploy Preview for vitest-dev ready!

Name Link
Latest commit 54bdfb10cc40b965d61ca85cfa11f34ac5b452b0
Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67595cf3d7adfc0008fb25a2
Deploy Preview https://deploy-preview-7067--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 11 '24 09:12 netlify[bot]

Decided to introduce the state() method on Suite and Module instead (similar to result() but without the errors): https://github.com/vitest-dev/vitest/pull/7069/files#diff-cd81764fa6513d3cb255c7299d25deeef63f842e17877bfc16ff9a75c783ddf6R356

sheremet-va avatar Dec 17 '24 15:12 sheremet-va

This is part of #7069

sheremet-va avatar Jan 13 '25 13:01 sheremet-va