vitest icon indicating copy to clipboard operation
vitest copied to clipboard

fix(ui): add errors and draft state (*) to the code editor

Open userquin opened this issue 1 year ago • 1 comments

Description

We have a regression somewhere, maybe updating Vue dependency, I'm not sure. The problem is that changes included in these 2 PR missing in current version:

  • https://github.com/vitest-dev/vitest/pull/1131
  • https://github.com/vitest-dev/vitest/pull/1039

This PR adds the draft indicator and the line error to the code editor: tested with test/core and test/browser (only preview).

This PR also includes:

  • codemirror optimizations when registering/unregistering the errors entries to remove memory leaks: looks like destroy method is missing in v6
  • changes the cursor to wait when saving the file: Video showing the cursor
  • registers the span listener to open the file in the editor (at line and column error), missing in the original PR #1131

imagen

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [x] Run the tests with pnpm test:ci.

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

userquin avatar Dec 07 '24 04:12 userquin

Deploy Preview for vitest-dev ready!

Name Link
Latest commit 29bcbeb97c82d97c93be66d130886efa75a5d81f
Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6753d2ebf7d8fe0008c20cea
Deploy Preview https://deploy-preview-7044--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 07 '24 04:12 netlify[bot]