vitest icon indicating copy to clipboard operation
vitest copied to clipboard

fix(runner): async assertion auto await should timeout

Open hi-ogawa opened this issue 1 year ago • 1 comments

Description

  • closes https://github.com/vitest-dev/vitest/issues/6386

Currently documentation indicates resolves/rejects needs to be manually awaited https://vitest.dev/api/expect.html#resolves, but "auto await" mechanism is added along with toMatchFileSnapshot https://github.com/vitest-dev/vitest/pull/3116/. It looks like the intent is to make "sync" API, so the documentation is outdated, but I'm not sure if we should encourage this "sync" API because it doesn't feel really intuitive anyway.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [x] Ideally, include a test that fails without this PR but passes with it.
  • [ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [ ] Run the tests with pnpm test:ci.

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa avatar Aug 25 '24 03:08 hi-ogawa

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
Latest commit ed3a95baf44d734b89e780397bd8953cee034ca1
Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66d1117e2a74a70008b45d4c
Deploy Preview https://deploy-preview-6391--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 25 '24 03:08 netlify[bot]