vitest icon indicating copy to clipboard operation
vitest copied to clipboard

docs: update error.ts for inlining a package

Open IAmLuisJ opened this issue 1 year ago • 4 comments

Description

Update recommended workaround for inlining a package that has a syntax error when resolving a bundled dependency, since the current workaround uses deprecated config options

close vitest-dev#6237

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [x] Ideally, include a test that fails without this PR but passes with it.
  • [x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [x] Run the tests with pnpm test:ci.

Documentation

  • [x] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

IAmLuisJ avatar Jul 29 '24 04:07 IAmLuisJ

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
Latest commit 857b82d2a64b73677281ea2293d4485276428912
Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66a71e32cee2ea000839dc07
Deploy Preview https://deploy-preview-6238--vitest-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 29 '24 04:07 netlify[bot]

server.deps.inline is not deprecated, deps.inline is

Using optimizer actually won't do anything unless it's enabled

sheremet-va avatar Jul 29 '24 17:07 sheremet-va

Oh I see. I believe my particular use case was alias configuration in a bundled dependency, which didn't work with the recommended solution. Would it be worth extending the error then instead of replacing it?

IAmLuisJ avatar Jul 29 '24 19:07 IAmLuisJ

Oh I see. I believe my particular use case was alias configuration in a bundled dependency, which didn't work with the recommended solution. Would it be worth extending the error then instead of replacing it?

How exactly do you want to extend it?

sheremet-va avatar Jul 31 '24 10:07 sheremet-va

We still recommend inlining

sheremet-va avatar Sep 05 '25 04:09 sheremet-va