vitest icon indicating copy to clipboard operation
vitest copied to clipboard

fix(coverage): remove work-around for implicit `else`

Open AriPerkkio opened this issue 1 year ago • 2 comments

Description

  • Upstream fix for istanbul-lib-source-maps was fixed and released, let's remove our patch
  • Ref. https://github.com/istanbuljs/istanbuljs/pull/706
  • Ref. https://github.com/vitest-dev/vitest/pull/2275

Test case:

https://github.com/vitest-dev/vitest/blob/b1a27d40493301f7b135b6ba99d52c9edc28fffb/test/coverage-test/test/implicit-else.istanbul.test.ts#L5-L20

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [x] Ideally, include a test that fails without this PR but passes with it.
  • [x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [x] Run the tests with pnpm test:ci.

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

AriPerkkio avatar Jul 01 '24 11:07 AriPerkkio

Updating istanbul-lib-source-maps breaks other coverage tests 🤔

AriPerkkio avatar Jul 01 '24 12:07 AriPerkkio

Another upstream fix set up in https://github.com/istanbuljs/istanbuljs/pull/789

AriPerkkio avatar Jul 01 '24 18:07 AriPerkkio