vitest icon indicating copy to clipboard operation
vitest copied to clipboard

Suggest timeout in the second arg, not last

Open xuhdev opened this issue 4 months ago • 3 comments

Timeout specified in the last argument is deprecated.

The doc says:

Vitest 1.3.0 deprecates the use of options as the last parameter.

xuhdev avatar Feb 22 '24 08:02 xuhdev

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
Latest commit 91239f89123abd3cbc3326dce1f1589a01405c8e
Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65e3ee0d657ec60008ba1808
Deploy Preview https://deploy-preview-5268--fastidious-cascaron-4ded94.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 22 '24 08:02 netlify[bot]

Timeout is the last argument, the options are the second argument.

sheremet-va avatar Feb 22 '24 08:02 sheremet-va

@sheremet-va Could you share a reference? I do not see a way to add a timeout directly as the last argument. I also updated the text and description for better clarity.

xuhdev avatar Feb 23 '24 02:02 xuhdev

@sheremet-va Would you mind taking another look :)

xuhdev avatar Mar 03 '24 03:03 xuhdev

@sheremet-va Would you mind taking another look :)

What I am trying to say is that the use of a number as the last argument was not deprecated—only the use of an object.

sheremet-va avatar Mar 03 '24 09:03 sheremet-va