website icon indicating copy to clipboard operation
website copied to clipboard

Update contribution guides

Open deepthi opened this issue 3 years ago • 4 comments

We have 3 guides: https://vitess.io/docs/contributing/build-on-macos/

  • asks you to install [email protected]. we should remove the @5.7 everywhere (4 occurrences). https://vitess.io/docs/contributing/build-on-ubuntu/
  • asks you to install go 1.17. Let us update that to go 1.18. https://vitess.io/docs/contributing/build-on-centos/
  • asks you to install go 1.17. Let us update that to go 1.18.

For golang, we may even want to say something like

Install the a version of Golang that is at least the one listed here https://github.com/vitessio/vitess/blob/main/build.env#L20

And then say

For example, at writing, the version is go1.18.7 and this is how you install it.

deepthi avatar Oct 21 '22 21:10 deepthi

Is it okay if I take on this issue? I can see it's already assigned, but it looks easy to solve.

PaarthAgarwal avatar Jan 30 '23 18:01 PaarthAgarwal

@PaarthAgarwal , yes please go ahead and assign it to yourself. Add me and @frouioui as a reviewer.

rsajwani avatar Feb 07 '23 20:02 rsajwani

@PaarthAgarwal , yes please go ahead and assign it to yourself. Add me and @frouioui as a reviewer.

Thanks for the approval, I don't think I have access to change assignees but will tag you both on my PR.

PaarthAgarwal avatar Feb 07 '23 21:02 PaarthAgarwal

@rsajwani I think this issue has been resolved already. Can you check?

PaarthAgarwal avatar Feb 08 '23 14:02 PaarthAgarwal