vitess icon indicating copy to clipboard operation
vitess copied to clipboard

Built-in string functions implementation: ASCII, BIN, BIT_LENGTH

Open wanghaoyang1995 opened this issue 3 years ago • 3 comments

Description

Add MySQL built-in functions ascii, bin, bit_length to evalengine.

Related Issue(s)

https://github.com/vitessio/vitess/issues/9647

Checklist

  • [ ] Should this PR be backported?
  • [x] Tests were added or are not required
  • [ ] Documentation was added or is not required

Deployment Notes

N/A

wanghaoyang1995 avatar Feb 27 '22 13:02 wanghaoyang1995

@vmg Hello,vmg. I have fixed some problems as suggested. For some case not defined in MySQL docs, there are different outputs between MySQL 5 and MySQL 8. Which one should I refer to?

wanghaoyang1995 avatar Mar 16 '22 12:03 wanghaoyang1995

For some case not defined in MySQL docs, there are different outputs between MySQL 5 and MySQL 8. Which one should I refer to?

That's great! We always target MySQL 8's behavior. It would be even better if you added a test for this specific mismatch with a comment that says it's not backwards compatible with MySQL 5.

vmg avatar Mar 16 '22 14:03 vmg

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions[bot] avatar Aug 08 '22 01:08 github-actions[bot]

This PR was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Aug 16 '22 01:08 github-actions[bot]