Bug Report: `TestSelectDateTypes` constantly failing

[rMaxiQp]

Overview of the Issue

I don't know if it's my local setup issue, my unit test keeps failing on TestSelectDateTypes

Reproduction Steps

$ source dev.env
$ make unit_test

Binary Version

$ git log --oneline
8ce3eb214f (HEAD -> main, origin/main, origin/HEAD) ci: remove code patching for error differences between versions (#18990)
719bd959ba CI: Improve reliability of codecov workflow with larger runner (#18992)

Operating System and Environment details

$ cat /etc/os-release
PRETTY_NAME="Ubuntu 24.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="24.04"
VERSION="24.04.3 LTS (Noble Numbat)"
VERSION_CODENAME=noble
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=noble
LOGO=ubuntu-logo
$ uname -sr
Linux 6.8.0-87-generic
$ uname -m
x86_64

Log Fragments

=== RUN   TestSelectDateTypes
    executor_select_test.go:4413: 
        	Error Trace:	/home/zq2/vitess/go/vt/vtgate/executor_select_test.go:4413
        	Error:      	Not equal: 
        	            	expected: "[[CHAR(\"2020-12-01\")]]"
        	            	actual  : "[[CHAR(\"2020-11-01\")]]"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-[[CHAR("2020-12-01")]]
        	            	+[[CHAR("2020-11-01")]]
        	Test:       	TestSelectDateTypes
--- FAIL: TestSelectDateTypes (0.01s)

[Git-HimanshuRathi]

Hi ! I'd like to work on this issue .

[rMaxiQp]

Hi @Git-HimanshuRathi, thank you for the volunteering! This issue surfaces on an earlier commit and I can't reproduce this issue locally after updating to the latest main branch. I don't know if this change applies to you or not, please feel free to try it out yourself as well.

[Git-HimanshuRathi]

I tested this on the latest main branch and can also confirm that TestSelectDateTypes passes successfully for me. Here is the test result .

hmshuu@Himanshus-MacBook-Air vitess % go test ./go/vt/vtgate -run TestSelectDateTypes -v === RUN TestSelectDateTypes --- PASS: TestSelectDateTypes (0.00s) PASS ok vitess.io/vitess/go/vt/vtgate 3.801s

[dbussink]

The issue here is likely due to the local timezone of your machine, depending if you're before or after UTC.