fix topo use in local_example
Description
The TOPO environment variable was not being passed into the docker environment for tests.
This meant that only etcd was ever being tested:
- zk was broken and has been fixed.
- consul is still broken and is now disabled. I believe this is safe, since in the docs it's been deprecated for some time.
Related Issue(s)
Fixes https://github.com/vitessio/vitess/issues/18355
Checklist
- [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
- [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
- [ ] Tests were added or are not required
- [ ] Did the new or modified tests pass consistently locally and on CI?
- [ ] Documentation was added or is not required
Deployment Notes
Review Checklist
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
General
- [ ] Ensure that the Pull Request has a descriptive title.
- [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.
Tests
- [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.
Documentation
- [ ] Apply the
release notes (needs details)label if users need to know about this change. - [ ] New features should be documented.
- [ ] There should be some code comments as to why things are implemented the way they are.
- [ ] There should be a comment at the top of each new or modified test to explain what the test does.
New flags
- [ ] Is this flag really necessary?
- [ ] Flag names must be clear and intuitive, use dashes (
-), and have a clear help text.
If a workflow is added or modified:
- [ ] Each item in
Jobsshould be named in order to mark it asrequired. - [ ] If the workflow needs to be marked as
required, the maintainer team must be notified.
Backward compatibility
- [ ] Protobuf changes should be wire-compatible.
- [ ] Changes to
_vttables and RPCs need to be backward compatible. - [ ] RPC changes should be compatible with vitess-operator
- [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
- [ ]
vtctlcommand output order should be stable andawk-able.
~Converting back to a draft, zk is broken too.~
Edit: ZK was fixed by https://github.com/vitessio/vitess/pull/18407 merging.
The deadlock issue causing the unit test / unit_race test to fail is https://github.com/vitessio/vitess/pull/18276 - I left a comment on the issue.
The code coverage test is failing due to a timeout in grpctmserver. It looks like a flaky test/unrelated.
Codecov Report
Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
Project coverage is 67.48%. Comparing base (
b111270) to head (11626f7). Report is 16 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| go/vt/topo/zk2topo/lock.go | 70.58% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #18357 +/- ##
==========================================
- Coverage 67.49% 67.48% -0.01%
==========================================
Files 1603 1603
Lines 262426 262490 +64
==========================================
+ Hits 177112 177138 +26
- Misses 85314 85352 +38
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.