Improve tablet types to wait

[ejortegau]

Description

This PR improves handling of vtgate --tablet_types_to_wait so that timeouts waiting for tablets are interpreted as not having successfully gotten healthchecks for all tablet types in all keyspaces of interest, leading to retries instead of simply logging the error and continuing.

Related Issue(s)

https://github.com/vitessio/vitess/issues/17412

Checklist

• [x] "Backport to:" labels have been added if this change should be back-ported to release branches
• [x] If this change is to be back-ported to previous releases, a justification is included in the PR description
• [x] Tests were added or are not required
• [x] Did the new or modified tests pass consistently locally and on CI?
• [x] Documentation was added or is not required

Deployment Notes

N/A

[vitess-bot[bot]]

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

• [ ] Ensure that the Pull Request has a descriptive title.
• [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• [ ] Apply the release notes (needs details) label if users need to know about this change.
• [ ] New features should be documented.
• [ ] There should be some code comments as to why things are implemented the way they are.
• [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• [ ] Is this flag really necessary?
• [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• [ ] Each item in Jobs should be named in order to mark it as required.
• [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• [ ] Protobuf changes should be wire-compatible.
• [ ] Changes to _vt tables and RPCs need to be backward compatible.
• [ ] RPC changes should be compatible with vitess-operator
• [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• [ ] vtctl command output order should be stable and awk-able.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (673e0d3) to head (65c7f8b). Report is 76 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtgate/vtgate.go	0.00%	14 Missing :warning:
go/vt/vtgate/tabletgateway.go	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17622      +/-   ##
==========================================
+ Coverage   67.54%   67.55%   +0.01%     
==========================================
  Files        1601     1601              
  Lines      261484   261494      +10     
==========================================
+ Hits       176612   176655      +43     
+ Misses      84872    84839      -33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[deepthi]

@ejortegau this still needs a note in the release notes summary file. It can go under "Minor Changes" in https://github.com/vitessio/vitess/blob/main/changelog/22.0/22.0.0/summary.md

[ejortegau]

@ejortegau this still needs a note in the release notes summary file. It can go under "Minor Changes" in https://github.com/vitessio/vitess/blob/main/changelog/22.0/22.0.0/summary.md

Added

[ejortegau]

Hi, team: Is there anything missing for this PR to be merged? Thanks!.

[harshit-gangal]

CI is failing, could be related to the changes

[github-actions[bot]]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions[bot]]

This PR was closed because it has been stale for 7 days with no activity.

[github-actions[bot]]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions[bot]]

This PR was closed because it has been stale for 7 days with no activity.