vitess icon indicating copy to clipboard operation
vitess copied to clipboard

VTAdmin(web): Add workflow start/stop actions

Open beingnoble03 opened this issue 1 year ago • 1 comments

Description

This PR adds the workflow start/stop actions in Workflows Screen.

Related Issue(s)

  • #11690

Screenshots

Screenshot 2024-08-29 at 1 10 50 PM Screenshot 2024-08-29 at 1 11 02 PM Screenshot 2024-08-29 at 1 11 17 PM Screenshot 2024-08-29 at 1 23 58 PM

Checklist

  • [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
  • [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
  • [ ] Tests were added or are not required
  • [ ] Did the new or modified tests pass consistently locally and on CI?
  • [ ] Documentation was added or is not required

Deployment Notes

beingnoble03 avatar Aug 28 '24 14:08 beingnoble03

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Aug 28 '24 14:08 vitess-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.91%. Comparing base (e89f684) to head (41cf462). Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16675      +/-   ##
==========================================
- Coverage   68.93%   68.91%   -0.03%     
==========================================
  Files        1564     1565       +1     
  Lines      201371   201685     +314     
==========================================
+ Hits       138821   138997     +176     
- Misses      62550    62688     +138     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 07 '24 04:09 codecov[bot]