vitess icon indicating copy to clipboard operation
vitess copied to clipboard

Replace Tablet QPS chart with `d3`

Open notfelineit opened this issue 1 year ago • 1 comments

Description

This PR will replace highcharts with d3 for the tablet QPS graph as a start.

Related Issue(s)

Checklist

  • [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
  • [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
  • [ ] Tests were added or are not required
  • [ ] Did the new or modified tests pass consistently locally and on CI?
  • [ ] Documentation was added or is not required

Deployment Notes

notfelineit avatar May 17 '24 18:05 notfelineit

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar May 17 '24 18:05 vitess-bot[bot]

I'll update the changelog in this PR as well, as well as update the old tests that reference old charts code.

notfelineit avatar May 31 '24 19:05 notfelineit

@mattlord I always intended to fix the linter issues 😄 my ask for review is for the structure and usage of the code.

notfelineit avatar May 31 '24 19:05 notfelineit

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.25%. Comparing base (bec711b) to head (8427b0e). Report is 2 commits behind head on main.

:exclamation: Current head 8427b0e differs from pull request most recent head 6c71610

Please upload reports for the commit 6c71610 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15970      +/-   ##
==========================================
+ Coverage   68.23%   68.25%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      197187   197168      -19     
==========================================
+ Hits       134546   134576      +30     
+ Misses      62641    62592      -49     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 31 '24 19:05 codecov[bot]

react changes look good to merge 🚀

no-itsbackpack avatar May 31 '24 19:05 no-itsbackpack