vitess icon indicating copy to clipboard operation
vitess copied to clipboard

Update `operator.yaml` and add schedule backup example

Open frouioui opened this issue 1 year ago • 1 comments

Description

This Pull Request adds one more step to the operator example: schedule backup. It comes at the very end of the guide, after Resharding. For this a new 401_ file is added.

The operator.yaml file is also modified to reflect the changes brought by https://github.com/planetscale/vitess-operator/pull/553.

Related Issue(s)

  • Website PR: https://github.com/vitessio/website/pull/1746
  • Vtop PR: https://github.com/planetscale/vitess-operator/pull/553

frouioui avatar May 17 '24 16:05 frouioui

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar May 17 '24 16:05 vitess-bot[bot]

Added "Do not merge" because the operator PR needs to be merged first, then this one, and then the website PR.

deepthi avatar May 31 '24 19:05 deepthi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.22%. Comparing base (9911880) to head (92fca3b). Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15969      +/-   ##
==========================================
- Coverage   68.45%   68.22%   -0.23%     
==========================================
  Files        1562     1541      -21     
  Lines      197057   197254     +197     
==========================================
- Hits       134891   134585     -306     
- Misses      62166    62669     +503     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 03 '24 21:06 codecov[bot]

DCO is working wrong right now, manually verified signoff

frouioui avatar Jun 03 '24 22:06 frouioui