vitess
vitess copied to clipboard
mysql: Handle more deprecated SQL commands
This deals with more deprecated SQL commands that now uses different terminology on newer MySQL versions.
Also refactors things to reduce some duplication and to simplify some logic. We now treat the latest syntax as default and keep older syntax for older versions as needed explicitly.
Related Issue(s)
Part of #9515
Checklist
- [x] "Backport to:" labels have been added if this change should be back-ported to release branches
- [x] If this change is to be back-ported to previous releases, a justification is included in the PR description
- [x] Tests were added or are not required
- [x] Did the new or modified tests pass consistently locally and on CI?
- [x] Documentation was added or is not required
Review Checklist
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
General
- [ ] Ensure that the Pull Request has a descriptive title.
- [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.
Tests
- [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.
Documentation
- [ ] Apply the
release notes (needs details)
label if users need to know about this change. - [ ] New features should be documented.
- [ ] There should be some code comments as to why things are implemented the way they are.
- [ ] There should be a comment at the top of each new or modified test to explain what the test does.
New flags
- [ ] Is this flag really necessary?
- [ ] Flag names must be clear and intuitive, use dashes (
-
), and have a clear help text.
If a workflow is added or modified:
- [ ] Each item in
Jobs
should be named in order to mark it asrequired
. - [ ] If the workflow needs to be marked as
required
, the maintainer team must be notified.
Backward compatibility
- [ ] Protobuf changes should be wire-compatible.
- [ ] Changes to
_vt
tables and RPCs need to be backward compatible. - [ ] RPC changes should be compatible with vitess-operator
- [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
- [ ]
vtctl
command output order should be stable andawk
-able.
Codecov Report
Attention: Patch coverage is 17.41573%
with 147 lines
in your changes are missing coverage. Please review.
Project coverage is 68.42%. Comparing base (
cbf89bd
) to head (6d7b1dc
). Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #15907 +/- ##
==========================================
- Coverage 68.43% 68.42% -0.02%
==========================================
Files 1559 1560 +1
Lines 196753 196920 +167
==========================================
+ Hits 134657 134742 +85
- Misses 62096 62178 +82
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.