vitess icon indicating copy to clipboard operation
vitess copied to clipboard

[release-19.0] Update VTAdmin build script (#15839)

Open vitess-bot[bot] opened this issue 9 months ago • 2 comments

Description

This is a backport of #15839

vitess-bot[bot] avatar May 06 '24 15:05 vitess-bot[bot]

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar May 06 '24 15:05 vitess-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.46%. Comparing base (2c42825) to head (cd0ca78).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15850      +/-   ##
================================================
- Coverage         67.47%   67.46%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192780   192780              
================================================
- Hits             130076   130064      -12     
- Misses            62704    62716      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 16:05 codecov[bot]