vitess icon indicating copy to clipboard operation
vitess copied to clipboard

feat: Add support for Insert with row alias

Open harshit-gangal opened this issue 1 year ago • 2 comments

Description

This adds planner support for new insert syntax insert into t(id, col) values(1, 'apa') as dt(x) on duplicate key col = x

Related Issue(s)

  • Closes https://github.com/vitessio/vitess/issues/12122

Checklist

  • [x] Tests were added or are not required
  • [x] Did the new or modified tests pass consistently locally and on CI?
  • [x] Documentation was added or is not required

Deployment Notes

harshit-gangal avatar Apr 25 '24 08:04 harshit-gangal

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Apr 25 '24 08:04 vitess-bot[bot]

Codecov Report

Attention: Patch coverage is 93.70629% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (96b1419) to head (d1c396b). Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/semantics/table_collector.go 92.78% 7 Missing :warning:
go/vt/vtgate/engine/insert.go 87.50% 1 Missing :warning:
go/vt/vtgate/semantics/vtable.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15790      +/-   ##
==========================================
- Coverage   68.44%   68.44%   -0.01%     
==========================================
  Files        1558     1558              
  Lines      195822   196129     +307     
==========================================
+ Hits       134032   134233     +201     
- Misses      61790    61896     +106     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 08:04 codecov[bot]