Multi-tenant MoveTables: Create vreplication streams only on specified shards
Description
Adds an option to provide shards for multi-tenant migrations. This will only create the workflow streams on the specified shard(s). It is expected that the user correctly maps the tenant id to the shard as per the configured vindex.
This PR also fixes a couple of places where we had either missed out or regressed on filtering our target shards for all MoveTables commands where shards were specified.
Related Issue(s)
https://github.com/vitessio/vitess/issues/15748
Checklist
- [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
- [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
- [ ] Tests were added or are not required
- [ ] Did the new or modified tests pass consistently locally and on CI?
- [ ] Documentation was added or is not required
Deployment Notes
Review Checklist
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
General
- [ ] Ensure that the Pull Request has a descriptive title.
- [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.
Tests
- [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.
Documentation
- [ ] Apply the
release notes (needs details)label if users need to know about this change. - [ ] New features should be documented.
- [ ] There should be some code comments as to why things are implemented the way they are.
- [ ] There should be a comment at the top of each new or modified test to explain what the test does.
New flags
- [ ] Is this flag really necessary?
- [ ] Flag names must be clear and intuitive, use dashes (
-), and have a clear help text.
If a workflow is added or modified:
- [ ] Each item in
Jobsshould be named in order to mark it asrequired. - [ ] If the workflow needs to be marked as
required, the maintainer team must be notified.
Backward compatibility
- [ ] Protobuf changes should be wire-compatible.
- [ ] Changes to
_vttables and RPCs need to be backward compatible. - [ ] RPC changes should be compatible with vitess-operator
- [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
- [ ]
vtctlcommand output order should be stable andawk-able.
Codecov Report
Attention: Patch coverage is 55.55556% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 68.43%. Comparing base (
ca2659d) to head (4a1db5d).
Additional details and impacted files
@@ Coverage Diff @@
## main #15746 +/- ##
==========================================
- Coverage 68.43% 68.43% -0.01%
==========================================
Files 1558 1558
Lines 196186 196201 +15
==========================================
+ Hits 134269 134270 +1
- Misses 61917 61931 +14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.