vitess icon indicating copy to clipboard operation
vitess copied to clipboard

feat: add coverage scripts

Open EshaanAgg opened this issue 1 year ago • 3 comments

Description

Edited the Makefile to add three new scripts:

  • coverage: This target runs the tests and generates a coverage report in the coverage.out file. It utilizes the go test command with the -coverprofile flag to collect coverage data. It can be run as make PACKAGE=<path to go package> coverage After running the same, the browser shows an HTML page indicating the current coverage. image

  • coverage-clean: This target removes the generated coverage file (coverage.out). It's useful for cleaning up after running coverage tests.

  • coverage-help: This target displays a usage message with information about available options and commands related to coverage.

Related Issue(s)

Fixes #15003

Checklist

  • [ ] "Backport to:" labels have been added if this change should be back-ported to release branches
  • [ ] If this change is to be back-ported to previous releases, a justification is included in the PR description
  • [ ] Tests were added or are not required
  • [ ] Did the new or modified tests pass consistently locally and on CI?
  • [ ] Documentation was added or is not required

Deployment Notes

EshaanAgg avatar Jan 23 '24 18:01 EshaanAgg

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • [ ] Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • [ ] Apply the release notes (needs details) label if users need to know about this change.
  • [ ] New features should be documented.
  • [ ] There should be some code comments as to why things are implemented the way they are.
  • [ ] There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • [ ] Is this flag really necessary?
  • [ ] Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Jan 23 '24 18:01 vitess-bot[bot]

I use the following alias to check to code coverage of any go package: alias check_coverage="go test ./... -coverprofile=cover.out && go tool cover -html=cover.out -o coverage.html && rm cover.out && firefox coverage.html" It is very flexible and can be used in any repository and in any directory without specifying the package name. I wonder if suggesting contributors to use a similar alias would be a better idea.

VaibhavMalik4187 avatar Jan 23 '24 19:01 VaibhavMalik4187

Seems cool, but how would you customize the package that you want to test and see the reports for with this alias? Running the tests for all the packages every time is not feasible.

EshaanAgg avatar Jan 23 '24 19:01 EshaanAgg

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions[bot] avatar Mar 08 '24 01:03 github-actions[bot]

This PR was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Mar 15 '24 01:03 github-actions[bot]